fix: distance - share with accountant #51517
Draft
+17
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paultsimura
commented
Oct 26, 2024
src/libs/ModifiedExpenseMessage.ts
Outdated
Comment on lines
142
to
144
| if (reportActionOriginalMessage?.movedToReportID) { | ||
| return "Moved this expense"; // todo: copy needed | ||
| } |
There was a problem hiding this comment.
@neil-marcellini could we please request a copy for this action?
It's added as the first report action after I share my tracked expense with an accountant.
There was a problem hiding this comment.
Don't we already have a message like this when moving a manual expense for example? Can we use the same copy?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR is intended to fix several issues with the tracked distance expenses shared with accountants.
Fixed Issues
$ #46897
PROPOSAL: #46897 (comment)
Tests
Same as QA
Offline tests
Same as QA
QA Steps
TBD
PR Author Checklist
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop