-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Skip onboarding screen with company size if signupQualifier is VSB #51839
base: main
Are you sure you want to change the base?
Conversation
@jayeshmangwani We need to move this logic create WS to the accounting page because |
@nkdengineer No issues with that—go ahead and open a PR for the WS creation logic on the accounting page. I'll review it once it's up. |
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@nkdengineer Could you please upload a video showing the process of going to the workspace for a new user(for VSB)? I’ve tested this with several new users, and I’m seeing CreateWorkspace being called twice. Let me know if you experience the same result with a new user |
@jayeshmangwani i updated, please check again |
@nkdengineer Is there any issue with testing on native devices? I noticed you haven’t added videos for those platforms yet. |
Welcome.setOnboardingAdminsChatReportID(); | ||
Welcome.setOnboardingPolicyID(); | ||
|
||
InteractionManager.runAfterInteractions(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a note explaining why we're using InteractionManager.runAfterInteractions here.
Explanation of Change
Fixed Issues
$ #51750
PROPOSAL: #51750 (comment)
Tests
how many employees
screen is skippedOffline tests
same as above
QA Steps
same as above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
android-mweb.mov
iOS: Native
iOS: mWeb Safari
ios-mweb.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov