-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the Create-an-Expense article as part of "Improve how we notify users of iou/expense report submissions" project #52161
Open
Christinadobrzyn
wants to merge
17
commits into
main
Choose a base branch
from
christina-update-create-expense-article
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+221
−164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating this help article based on this GH- Expensify/Expensify#438175
A preview of your ExpensifyHelp changes have been deployed to https://22d096b3.helpdot.pages.dev ⚡️ |
Just edited one of the sentences about submitting an expense to a workspace to make it more clear.
Made the Create an Expense title a header and trying to fix an issue with the mobile app steps. They aren't displayed properly
trying to fix the mobile app/desktop switcher
trying to fix the mobile app or desktop switch
trying to fix the mobile app / desktop switch.
Updating the Approve and pay help article to just Approve workflows - related to this GH Expensify/Expensify#438175
adding a redirect for the help article name change of https://help.expensify.com/articles/new-expensify/expenses-&-payments/Approve-and-pay-expenses to https://help.expensify.com/articles/new-expensify/expenses-&-payments/Approve-expenses
trying to fix the mobile app/ desktop switch
Forgot to add {% include end-selector.html %} to the doc - added to resolve the layout issue
Making a chance to formatting and removing the images because they are outdated
Trying to get a space between the steps in the hold section
still trying to fix the Hold switch section, trying something different.
the hold section still looks bad, trying another fix
Trying to get the hold section better
@Christinadobrzyn it should render properly now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.