Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require github repository, we will use the default value #17

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

AndrewGable
Copy link
Contributor

Details

Fixes error seen here: https://github.com/Expensify/eslint-config-expensify/actions/runs/11392661829

I had incorrectly assumed that the default param would work with a required variable, but it does not.

Related Issues

https://github.com/Expensify/Expensify/issues/432173

@AndrewGable AndrewGable self-assigned this Oct 17, 2024
@AndrewGable AndrewGable merged commit 385b0ca into main Oct 17, 2024
1 check passed
@AndrewGable AndrewGable deleted the andrew-required-param branch October 17, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants