Skip to content

Commit

Permalink
fix update snapshot assignment to merge existing values instead of ov…
Browse files Browse the repository at this point in the history
…erwriting
  • Loading branch information
huult committed Nov 1, 2024
1 parent b58dbc5 commit de00a22
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions lib/Onyx.ts
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,7 @@ function updateSnapshots(data: OnyxUpdate[]) {
return;
}

let updatedData = {};
let updatedData: Record<string, unknown> = {};

data.forEach(({key, value}) => {
// snapshots are normal keys so we want to skip update if they are written to Onyx
Expand All @@ -573,7 +573,10 @@ function updateSnapshots(data: OnyxUpdate[]) {
return;
}

updatedData = {...updatedData, [key]: lodashPick(value, Object.keys(snapshotData[key]))};
const oldValue = updatedData[key] || {};
const newValue = lodashPick(value, Object.keys(snapshotData[key]));

updatedData = {...updatedData, [key]: Object.assign(oldValue, newValue)};
});

// Skip the update if there's no data to be merged
Expand Down

0 comments on commit de00a22

Please sign in to comment.