Load text-encoding for older versions only
#226
+6,923
−21,902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
CLABotify
added a commit
to Expensify/CLA
that referenced
this pull request
Dec 18, 2024
|
recheck |
This is the cleanest approach I could think of. Any Metro related solution will require involved steps from the library users. Compared to just adding a line to the README explaining how to use the package with older versions of RN bundler solutions seems overkill.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Only load the
text-encodinglibrary on older versions of RN.This is the cleanest approach I could think of. Any Metro related
solution will require involved steps from the library users. Compared
to just adding a line to the README explaining how to use the package
with older versions of RN bundler solutions seems overkill.
What this fixes
This is a partial requirement for Expensify/App#54096
Checklist
ExampleAppExampleApp on all platforms:iOSScreenshots/Videos