-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds documentation for LES models and governing equations #1495
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor question, is it possible to have literature sources here as well? If we want to have this as a proper and stand alone documentation, maybe one has to add specify sources (for Vreman for example) as well. Of course, we also have this in the code via the DOIs but to make it complete maybe this would be nice. I can also add this stuff, just don't know if (a) it works in this environment (b) this is supported by the other developers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if one can add an actual bibliography, maybe we can ask in the dev meeting. But we can of course have the DOIs in the documentation as well.
@@ -25,9 +40,10 @@ differ from case to case. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To my opinion we either write this part for the temperature, then we have to replace s by T in the equation. Or we write this for a scalar s. This also depends a bit on how to continue. If we are going to consider cases where energy equation has to be solved and density variation are considered via Boussinesq approximation in the momentum conservation equation ..... then we also have to expand this for LES (
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the table, the cpldcg-option has to be added for the velocity solve, right?
See changes in the files.
Maybe just to confirm, for the scalar, we can always have the derivatve outside the viscosity and varying viscosity, right? We need no special treatment for it, as far as I can see.
Also sneaks in a gitignore in the reframe directory.