Fix: Stop Using Previous VOD to Set timeOffset #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nfrederiksen
changed the title
Nfrederiksen
changed the title
birme
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR will change the behavior of handling ProgramDateTime when loading one vod after another.
The previous behavior was to ignore the set
this.timeOffsettimestamp and, instead, have it timeOffset rather be the timestamp of the final segment in the previous vod. This might not always yield in real-time timestamps as it assumes that the time of loading matches the time on the timestamp on that final segment. This is not always the case and even when it does not align with the true real-time, and there is no way to adjust the PDT in order to sync up later.By using this updated behavior, the timeOffset will no longer be influenced by the previous vod. It only uses the value it gets from the initialization, which could help syncing the PDT with real-time, assuming that the given timeOffset in the constructor is a more dependable one.