feat: mp4 mode handling #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwallberg
commented
Sep 27, 2024
src/media-event-filter.ts
Outdated
| @@ -27,6 +27,9 @@ type TFilteredMediaEventCallback = (event: FilteredMediaEvent) => void; | |||
| type TMediaEventFilterOptions = { | |||
| mediaElement: HTMLMediaElement; | |||
| callback: TFilteredMediaEventCallback; | |||
| // Should be set to `true` when playing MP4 files directly on the video element | |||
| // as the video element CAN stop buffering when readyState is 3 rather than 4. | |||
| mp4Mode: boolean | |||
There was a problem hiding this comment.
don't particularly like the name but it's informative 😅
martinstark
reviewed
Sep 27, 2024
martinstark
reviewed
Sep 27, 2024
martinstark
approved these changes
Sep 27, 2024
bwallberg
force-pushed
the
feat/mp4mode
branch
from
cf4dd82
to
b1b4077
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat canplay as canplaythrough if mp4mode is enabled.