Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to include signal in the data/MC ratio #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eshwen
Copy link
Contributor

@eshwen eshwen commented Oct 13, 2020

Previously, signal was not included at any point when computing the data/MC ratio. Added a config file kwarg signal_in_ratio that, when set to True, includes signal as part of "MC" when calculating data/MC. Defaults to False to preserve original calculation

@eshwen eshwen marked this pull request as draft October 13, 2020 11:55
@eshwen eshwen marked this pull request as ready for review October 13, 2020 11:56
@benkrikler
Copy link
Member

I'm a little unsure about the consequence of this change and I wonder if the intention is clear enough from the name of the new option. From the description, I understood you want to overlay lines for including the signal in the ratio plot, but from the implementation I think you still only have one line but that now includes the signal in the sum on the background. I think the change is ok otherwise, but I'd like to confirm this first...

@eshwen
Copy link
Contributor Author

eshwen commented Oct 14, 2020

The idea is to be able to include signal when calculating the data/MC ratio (i.e., data/S+B instead of just data/B). It's only necessary in specific use cases, like making post-fit plots from a S+B background fit (i.e., if the background doesn't describe your data fully, then signal plugs the gap to some extent) where it's more informative for the ratio to be data/S+B.

I don't need any extra lines or anything like that. Well, the ability to display two ratios (i.e., pre-fit and post-fit data/MC) would be good, but that's a different thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants