-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some updates related to dualspace #194
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trimmed serendipity
Merge fenics
Merge FEniCS
Ksagiyam/merge upstream
Update to current fenics master.
nbouziani
commented
Sep 11, 2023
dham
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a few issues related to the recent dual space changes in UFL (#87).
The main changes are:
BaseForm
objects with acoefficients
slot.BaseForm
objects with aufl_domain
as they can be differentiated, which requires inferring the underlying domain.Cofunction
s now have one argument in the primal space as they map from V to R.Coargument
s now have two arguments. In fact,Coargument
s map from V* to V*, i.e. V* -> V*, or equivalently V* x V -> R, hence they have one argument in the primal space and one in the dual space.BaseFormCoordinateDerivative
and fix the argument analysis forBaseFormDerivative
objects.Action
differentiation ruleAdjoint
differentiation(cf. firedrakeproject#39)