Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some updates related to dualspace #194

Merged
merged 55 commits into from
Sep 12, 2023
Merged

Conversation

nbouziani
Copy link
Contributor

This PR addresses a few issues related to the recent dual space changes in UFL (#87).

The main changes are:

  • Equip BaseForm objects with a coefficients slot.
  • Equip BaseForm objects with a ufl_domain as they can be differentiated, which requires inferring the underlying domain.
  • Cofunctions now have one argument in the primal space as they map from V to R.
  • Coarguments now have two arguments. In fact, Coarguments map from V* to V*, i.e. V* -> V*, or equivalently V* x V -> R, hence they have one argument in the primal space and one in the dual space.
  • Add BaseFormCoordinateDerivative and fix the argument analysis for BaseFormDerivative objects.
  • Update Action differentiation rule
  • Remove support for Adjoint differentiation

(cf. firedrakeproject#39)

rckirby and others added 30 commits February 27, 2020 11:19
ufl/algorithms/map_integrands.py Show resolved Hide resolved
ufl/argument.py Show resolved Hide resolved
ufl/coefficient.py Show resolved Hide resolved
@dham dham marked this pull request as ready for review September 12, 2023 17:02
@dham dham merged commit 30b22c0 into FEniCS:main Sep 12, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants