add docker-compose-dev #554
Conversation
|
@chhsiao1981 I think this should go in a new separate repo. |
|
@jbernal0019 how come? The added files for docker-compose are for the purpose of CUBE development, with the CUBE source code mounted into the container. I think this should be merged. The next steps would be to move the imperative invocation of steps e.g. unit tests and integration tests into the docker-compose YAML too, so that unit tests and integration tests can be invoked simply by calling |
|
Given that this PR is extremely helpful in ChRIS_ultron_backEnd development / seeing how ChRIS_ultron_backEnd really works, I strongly recommend that this PR be merged. cc: @jennydaman |
chhsiao1981
force-pushed
the
docker-compose-dev
branch
from
cbff2ba to
a6f8a18
Compare
docker-compose-dev.yml
Outdated
| - pip install -r /opt/ChRIS_ultron_backEnd/requirements/local.txt && python manage.py migrate --noinput | ||
| volumes: | ||
| - chris_files:/var/chris:rw | ||
| - ./chris_backend:/opt/app-root/src |
There was a problem hiding this comment.
What is the reason we need to mount /opt/app-root/src and /opt/ChRIS_ultron_backEnd?
Also, should we use :ro on the source file mounts?
There was a problem hiding this comment.
Thanks for the feedback.
/opt/app-root/srcis for the entrypoint, and/opt/ChRIS_ultron_backEndis to easily know what we are running.:rois good to have, but the goal of thisdocker-compose-dev.ymlis for development. I don't think:rois necessary though～
docker-compose-dev.yml
Outdated
|
|
||
| chris: | ||
| container_name: chris | ||
| image: ghcr.io/fnndsc/cube:5.0.0 |
There was a problem hiding this comment.
Since many of these services specify pip install -r ... in their command, I would suggest using a docker-compose build.
docker-compose-dev.yml
Outdated
| image: ghcr.io/fnndsc/chris_ui:latest-staging | ||
| command: sirv --host --single | ||
| environment: | ||
| REACT_APP_CHRIS_UI_URL: http://localhost:8000/api/v1/ |
There was a problem hiding this comment.
I think the environment variables should be VITE_APP_CHRIS_UI_URL and VITE_APP_PFDCM_URL
| image: ghcr.io/fnndsc/pman:6.0.1 | ||
| container_name: pman | ||
| environment: | ||
| CONTAINER_ENV: docker |
There was a problem hiding this comment.
Note: this is a breaking change.
pman needs to create containers using Docker. There are two available APIs for this:
- Docker API: simpler code and usage
- Swarm API: more complicated
There are different features available depending on whether the Docker API or Swarm API is used. For example, the Docker API supports configurations CONTAINER_USER and SHM_SIZE, but does not support GPU. The Swarm API does not support CONTAINER_USER nor SHM_SIZE but Swarm API does work with GPU.
The discrepancy in features is not a technical limitation but rather just laziness.
While I strongly suggest using CONTAINER_ENV=docker, @jbernal0019, who is the main contributor of ChRIS_ultron_backEnd, is against CONTIANER_ENV=docker and favors CONTAINER_ENV=swarm.
More context: https://github.com/fnndsc/pman?tab=readme-ov-file#swarm-vs-docker
There was a problem hiding this comment.
Thanks for the feedback.
I believe that the goal for docker-compose-dev.yml is for development only, not for production.
having CONTAINER_ENV=docker should be enough for quick development.
There was a problem hiding this comment.
pman was updated in FNNDSC/pman@5b6f202 to support GPUs with CONTAINER_ENV=docker
…PFDCM_URL to VITE_APP_PFDCM_URL
chhsiao1981
force-pushed
the
docker-compose-dev
branch
from
1616e56 to
ccf595c
Compare
chhsiao1981
force-pushed
the
docker-compose-dev
branch
from
ccf595c to
e463a76
Compare
|
Closing in favor of #566 |
add docker-compose-dev