Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix construction of required parameters #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aravindhp
Copy link

serverPort in commandSuffix() is being treated as an integer when constructing a string. This commit fixes that by converting it into a string.
Ref: FNNDSC/ChRIS_ultron_backEnd#222 (comment)

"serverPort" in commandSuffix() is being treated as an integer when
constructing a string. This commit fixes that by converting it into a
string.
Ref: FNNDSC/ChRIS_ultron_backEnd#222 (comment)
@aravindhp
Copy link
Author

Looks like this did not fix the issue seen in FNNDSC/ChRIS_ultron_backEnd#222 (comment)

@aravindhp
Copy link
Author

aravindhp commented Dec 28, 2020

The problem was with how I was testing the fix. This PR fixed the issue. Please review @rudolphpienaar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant