Mini (R52) CAN dash #427
Draft
Mini (R52) CAN dash #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmschulte
commented
May 23, 2024
| if (cycle.isInterval(CI::_50ms)) { | ||
| { // block scope to invoke CanTxMessage deconstructor (send) | ||
| CanTxMessage msg(CAN_MINI_DME1_ID, 8); | ||
| msg.setShortValue(rpm * 6.4, 3); |
There was a problem hiding this comment.
In my tests, this was indeed big-endian vs little-endian as others have noted. I need to confirm with a second unit and some closer analysis.
nmschulte
commented
May 23, 2024
| } | ||
| } | ||
| } | ||
| } else if (cycle.isInterval(CI::_500ms)) { |
There was a problem hiding this comment.
this will never hit ... (50 divides 500 evenly ...)
nmschulte
force-pushed
the
nms/mini-can-dash
branch
from
4e47ff2
to
a548418
Compare
nmschulte
force-pushed
the
nms/mini-can-dash
branch
from
a548418
to
85e2f39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.