Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add speaker info to xml export #267

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

loomchild
Copy link
Contributor

Adds speaker slug, biography and other info to the xml export in a new persons section.

Alternative to #266

@loomchild
Copy link
Contributor Author

loomchild commented Dec 1, 2024

I would like to also add the speaker photo, but I see it's a bit more complicated by looking at layouts/schedule/speaker.html. Could you share how the speaker object looks like in sample/export/pentabarf.yaml (as I don't have access to the actual export)?

I think speaker photo is not critical and can be complicated (considering resizing, etc.), so I can propose a separate PR for it.

@johanvdw
Copy link
Member

johanvdw commented Dec 2, 2024

I think speaker photo is not critical and can be complicated (considering resizing, etc.), so I can propose a separate PR for it.

I'm planning a change to the URL's generated for attachments and speaker images. It may simplify things so I would wait for that.

@johanvdw
Copy link
Member

you should still add the id or slug to the speakers per talk (similar to my pr) otherwise you can not link both together.

@loomchild
Copy link
Contributor Author

You are right, I'll look into this ASAP.

@loomchild
Copy link
Contributor Author

@johanvdw Actually, there's already person_id stored under id attribute for each speaker of the event. Could you confirm that it's insufficient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants