-
Notifications
You must be signed in to change notification settings - Fork 18
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add outer class name inheriting visitor (#89)
- Loading branch information
1 parent
9c627c7
commit 1046304
Showing
3 changed files
with
471 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
203 changes: 203 additions & 0 deletions
203
src/main/java/net/fabricmc/mappingio/adapter/OuterClassNameInheritingVisitor.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,203 @@ | ||
/* | ||
* Copyright (c) 2023 FabricMC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package net.fabricmc.mappingio.adapter; | ||
|
||
import java.io.IOException; | ||
import java.util.Arrays; | ||
import java.util.EnumSet; | ||
import java.util.HashMap; | ||
import java.util.HashSet; | ||
import java.util.List; | ||
import java.util.Map; | ||
import java.util.Set; | ||
import java.util.regex.Pattern; | ||
|
||
import org.jetbrains.annotations.Nullable; | ||
|
||
import net.fabricmc.mappingio.MappedElementKind; | ||
import net.fabricmc.mappingio.MappingFlag; | ||
import net.fabricmc.mappingio.MappingUtil; | ||
import net.fabricmc.mappingio.MappingVisitor; | ||
|
||
/** | ||
* Searches for inner classes with no mapped name, whose enclosing classes do have mapped names, | ||
* and applies those to the outer part of the inner classes' fully qualified name. | ||
* | ||
* <p>For example, it takes a class {@code class_1$class_2} that doesn't have a mapping, | ||
* tries to find {@code class_1}, which let's say has the mapping {@code SomeClass}, | ||
* and changes the former's destination name to {@code SomeClass$class_2}. | ||
*/ | ||
public class OuterClassNameInheritingVisitor extends ForwardingMappingVisitor { | ||
protected OuterClassNameInheritingVisitor(MappingVisitor next) { | ||
super(next); | ||
} | ||
|
||
@Override | ||
public Set<MappingFlag> getFlags() { | ||
Set<MappingFlag> ret = EnumSet.noneOf(MappingFlag.class); | ||
ret.addAll(next.getFlags()); | ||
ret.add(MappingFlag.NEEDS_MULTIPLE_PASSES); | ||
|
||
return ret; | ||
} | ||
|
||
@Override | ||
public boolean visitHeader() throws IOException { | ||
if (pass < firstEmitPass) return true; | ||
|
||
return super.visitHeader(); | ||
} | ||
|
||
@Override | ||
@SuppressWarnings("unchecked") | ||
public void visitNamespaces(String srcNamespace, List<String> dstNamespaces) throws IOException { | ||
dstNsCount = dstNamespaces.size(); | ||
|
||
if (pass == collectClassesPass) { | ||
visitedDstName = new boolean[dstNsCount]; | ||
dstNameBySrcNameByNamespace = new HashMap[dstNsCount]; | ||
} else if (pass >= firstEmitPass) { | ||
super.visitNamespaces(srcNamespace, dstNamespaces); | ||
} | ||
} | ||
|
||
@Override | ||
public void visitMetadata(String key, @Nullable String value) throws IOException { | ||
if (pass < firstEmitPass) return; | ||
|
||
super.visitMetadata(key, value); | ||
} | ||
|
||
@Override | ||
public boolean visitContent() throws IOException { | ||
if (pass < firstEmitPass) return true; | ||
|
||
return super.visitContent(); | ||
} | ||
|
||
@Override | ||
public boolean visitClass(String srcName) throws IOException { | ||
this.srcName = srcName; | ||
|
||
if (pass == collectClassesPass) { | ||
dstNamesBySrcName.putIfAbsent(srcName, new String[dstNsCount]); | ||
} else if (pass >= firstEmitPass) { | ||
super.visitClass(srcName); | ||
} | ||
|
||
return true; | ||
} | ||
|
||
@Override | ||
public void visitDstName(MappedElementKind targetKind, int namespace, String name) throws IOException { | ||
if (pass == collectClassesPass) { | ||
if (targetKind != MappedElementKind.CLASS) return; | ||
|
||
dstNamesBySrcName.get(srcName)[namespace] = name; | ||
} else if (pass >= firstEmitPass) { | ||
if (targetKind == MappedElementKind.CLASS) { | ||
visitedDstName[namespace] = true; | ||
name = dstNamesBySrcName.get(srcName)[namespace]; | ||
} | ||
|
||
super.visitDstName(targetKind, namespace, name); | ||
} | ||
} | ||
|
||
@Override | ||
public void visitDstDesc(MappedElementKind targetKind, int namespace, String desc) throws IOException { | ||
if (pass < firstEmitPass) return; | ||
|
||
if (modifiedClasses.contains(srcName)) { | ||
Map<String, String> nsDstNameBySrcName = dstNameBySrcNameByNamespace[namespace]; | ||
|
||
if (nsDstNameBySrcName == null) { | ||
dstNameBySrcNameByNamespace[namespace] = nsDstNameBySrcName = dstNamesBySrcName.entrySet() | ||
.stream() | ||
.filter(entry -> entry.getValue()[namespace] != null) | ||
.collect(HashMap::new, (map, entry) -> map.put(entry.getKey(), entry.getValue()[namespace]), HashMap::putAll); | ||
} | ||
|
||
desc = MappingUtil.mapDesc(desc, nsDstNameBySrcName); | ||
} | ||
|
||
super.visitDstDesc(targetKind, namespace, desc); | ||
} | ||
|
||
@Override | ||
public boolean visitElementContent(MappedElementKind targetKind) throws IOException { | ||
if (targetKind == MappedElementKind.CLASS && pass > collectClassesPass) { | ||
String[] dstNames = dstNamesBySrcName.get(srcName); | ||
|
||
for (int ns = 0; ns < dstNames.length; ns++) { | ||
String dstName = dstNames[ns]; | ||
|
||
if (pass == fixOuterClassesPass) { | ||
if (dstName != null) continue; // skip if already mapped | ||
|
||
String[] parts = srcName.split(Pattern.quote("$")); | ||
|
||
for (int pos = parts.length - 2; pos >= 0; pos--) { | ||
String outerSrcName = String.join("$", Arrays.copyOfRange(parts, 0, pos + 1)); | ||
String outerDstName = dstNamesBySrcName.get(outerSrcName)[ns]; | ||
|
||
if (outerDstName != null) { | ||
dstName = outerDstName + "$" + String.join("$", Arrays.copyOfRange(parts, pos + 1, parts.length)); | ||
|
||
dstNames[ns] = dstName; | ||
modifiedClasses.add(srcName); | ||
break; | ||
} | ||
} | ||
} else if (!visitedDstName[ns]) { | ||
if (dstName == null) continue; // skip if not mapped | ||
|
||
// Class didn't have a mapping before we added one, | ||
// so we have to call visitDstName manually. | ||
super.visitDstName(targetKind, ns, dstName); | ||
} | ||
} | ||
} | ||
|
||
if (pass < firstEmitPass) { | ||
return false; // prevent other element visits, we only care about classes here | ||
} | ||
|
||
Arrays.fill(visitedDstName, false); | ||
return super.visitElementContent(targetKind); | ||
} | ||
|
||
@Override | ||
public boolean visitEnd() throws IOException { | ||
if (pass++ < firstEmitPass) { | ||
return false; | ||
} | ||
|
||
return super.visitEnd(); | ||
} | ||
|
||
private static final int collectClassesPass = 1; | ||
private static final int fixOuterClassesPass = 2; | ||
private static final int firstEmitPass = 3; | ||
private final Map<String, String[]> dstNamesBySrcName = new HashMap<>(); | ||
private final Set<String> modifiedClasses = new HashSet<>(); | ||
private int pass = 1; | ||
private int dstNsCount = -1; | ||
private String srcName; | ||
private boolean[] visitedDstName; | ||
private Map<String, String>[] dstNameBySrcNameByNamespace; | ||
} |
Oops, something went wrong.