Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last changes for 0.7 #109

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

Last changes for 0.7 #109

wants to merge 4 commits into from

Conversation

NebelNidas
Copy link
Collaborator

Can be merged without squashing, if deemed appropriate.

@NebelNidas NebelNidas changed the title Last changes to 0.7 Last changes for 0.7 Aug 26, 2024
@NebelNidas NebelNidas added this to the 0.7.0 milestone Aug 26, 2024
modmuss50
modmuss50 reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small thing regarding the asm update.

gradle.properties Outdated Show resolved Hide resolved
@NebelNidas
Update dependencies
9f9c3a9
@NebelNidas
Update Spotless and Checkstyle configurations
a709f21 
Should now be in line with most other Fabric projects.
@NebelNidas
Use @implNote in MappingFormat Javadocs
e8956a9 
Also adds a missing note to the IntelliJ migration map format.
@NebelNidas
Adjust Javadocs to clarify lvIndex refers to slot
383c72d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modmuss50 modmuss50 modmuss50 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@NebelNidas @modmuss50