Handle NEEDS_MULTIPLE_PASSES more consistently
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
I can rework this to use readers everywhere once #82 is merged. Edit: Done! |
NebelNidas
force-pushed
the
consistent-multiple-passes-handling
branch
from
98fa24d
to
a7e55e5
Compare
NebelNidas
force-pushed
the
consistent-multiple-passes-handling
branch
from
a7e55e5
to
9ea86e0
Compare
modmuss50
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now usesMemoryMappingTrees for intermediate storage everywhere. Removing the reader gymnastics reduces the chance of accidentally introducing bugs, and improves code readability along the way.Rewritten to use the overhauled
ColumnFileReader's improvedmark()everywhere.