Add MappingFormat#hasWriter
#83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NebelNidas
force-pushed
the
mappingformat-hasWriter-boolean
branch
from
b1a4bca
to
bc3d4bf
Compare
modmuss50
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an easy way for querying whether or not a given
MappingFormathas an associated writer available. This makes it easier for applications like Enigma to display a dropdown with all writable formats, instead of hardcoding the list or erroring after the fact.MappingWriter#create's return value isn't a viable alternative, since you have to pass a valid path orjava.io.Writerto it before being able to obtain a result.