Add IntelliJ Idea Migration Map reader and writer #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
approved these changes
Aug 23, 2024
NebelNidas
force-pushed
the
migration-map
branch
from
67613d9
to
662b2d4
Compare
Also improves header validation for formats with headers
NebelNidas
force-pushed
the
migration-map
branch
from
662b2d4
to
5f09938
Compare
liach
reviewed
Aug 25, 2024
src/main/java/net/fabricmc/mappingio/format/intellij/MigrationMapFileReader.java
Outdated
Show resolved
Hide resolved
True, I was adding some header validation tests to the migration map format and thought I might do the same for the other applicable formats as well while already being at it. Doesn't quite warrant a separate PR in my opinion.
Perfect, LGTM then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #92 and closes #61.