Reproducer for control misbehavior

[ktf]

This is a reproducer for my issue in DPL with the interactive control. You can run it with:

./examples/1-1/fairmq-ex-1-1-sampler --control interactive

and it will exhibit the same unexpected behaviour:

[09:37:01][STATE] INITIALIZING TASK ---> READY
[09:37:01][STATE] READY ---> RUNNING
[09:37:01][INFO] Switching toSTOP

[09:37:01][INFO] fair::mq::Device running...
[09:37:01][STATE] RUNNING ---> READY
[09:37:01][INFO] Switching toRESET TASK

[09:37:01][STATE] READY ---> RESETTING TASK
[09:37:01][INFO] Switching toRESET DEVICE

[09:37:01][STATE] No transition from state RESETTING_TASK on transition RESET_DEVICE
[09:37:01][STATE] RESETTING TASK ---> DEVICE READY
[09:37:01][INFO] Switching toEND

[09:37:01][STATE] No transition from state DEVICE_READY on transition END

[ktf]

Again I think the issue is the the automatic transitions do not take into account the original state of a given transition.

[dennisklein]

Most simple fix I can think of:

Suggested change

	ChangeState(transitions.back());
	transitions.pop_back();
	if (ChangeState(transitions.back())) {
	transitions.pop_back();
	}

[dennisklein]

We discussed the topic at length in a private mm chat last week, for agreed upon improvements see #441, #442, #443.