Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] New OFI impl #65

Closed
wants to merge 6 commits into from
Closed

[WIP] New OFI impl #65

wants to merge 6 commits into from

Conversation

dennisklein
Copy link
Member

@dennisklein dennisklein commented Jul 30, 2018

Resolves #54
Resolves #9


Checklist:

@dennisklein dennisklein added this to the v1.3 milestone Jul 30, 2018
@dennisklein dennisklein self-assigned this Jul 30, 2018
@codecov
Copy link

codecov bot commented Jul 30, 2018

Codecov Report

Merging #65 into dev will decrease coverage by 7.19%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev      #65     +/-   ##
=========================================
- Coverage   58.72%   51.53%   -7.2%     
=========================================
  Files          69       78      +9     
  Lines        4235     4824    +589     
=========================================
- Hits         2487     2486      -1     
- Misses       1748     2338    +590
Impacted Files Coverage Δ
fairmq/ofi/Socket.h 0% <ø> (ø)
fairmq/ofi/Context.cxx 0.62% <ø> (ø)
fairmq/ofi/TransportFactory.cxx 3.33% <ø> (ø)
fairmq/ofi/Context.h 0% <ø> (ø)
fairmq/ofi/Socket.cxx 0% <0%> (ø)
fairmq/tools/Strings.h 0% <0%> (-100%) ⬇️
fairmq/FairMQTransportFactory.cxx 57.14% <0%> (-9.53%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b3e3bb...862742a. Read the comment docs.

@dennisklein dennisklein changed the title [WIP] Adopt O2 pmrs and small changes [WIP] Adopt O2 pmrs, new OFI impl and small changes Aug 2, 2018
@dennisklein dennisklein changed the title [WIP] Adopt O2 pmrs, new OFI impl and small changes [WIP] Adopt O2 pmrs and new OFI impl Aug 9, 2018
@dennisklein dennisklein changed the title [WIP] Adopt O2 pmrs and new OFI impl [WIP] New OFI impl Sep 6, 2018
@dennisklein
Copy link
Member Author

Closing in favor of new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants