reduce contribution collection for pack listings

Faithful-Resource-Pack · Jan 17, 2024 · 48cdbb5 · 48cdbb5
1 parent 1360bbd
commit 48cdbb5
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 6 deletions.
diff --git a/src/v2/interfaces/contributions.ts b/src/v2/interfaces/contributions.ts
@@ -59,7 +59,7 @@ export interface ContributionsRepository {
 	updateContribution(id: string, params: ContributionCreationParams): Promise<Contribution>;
 	getByDateRange(begin: string, ends: string): Promise<Contributions>;
 	getAuthors(): Promise<ContributionsAuthors>;
-	getPacks(): FaithfulPack[];
+	getPacks(): Promise<FaithfulPack[]>;
 	searchByIdAndPacks(
 		textureIDs: Array<string>,
 		packs: Array<string>,

diff --git a/src/v2/repository/firestorm/contributions.repository.ts b/src/v2/repository/firestorm/contributions.repository.ts
@@ -4,7 +4,6 @@ import {
 	Contributions,
 	ContributionsRepository,
 	ContributionsAuthors,
-	FaithfulPacksArr,
 	FaithfulPack,
 } from "../../interfaces";
 import { contributions, users } from "../../firestorm";
@@ -14,8 +13,18 @@ export default class ContributionFirestormRepository implements ContributionsRep
 		return contributions.get(id);
 	}
 
-	getPacks(): FaithfulPack[] {
-		return [...FaithfulPacksArr] as FaithfulPack[];
+	getPacks(): Promise<FaithfulPack[]> {
+		return contributions.select({ fields: ["pack"] }).then((res: Contributions) =>
+			(
+				Object.values(res).reduce(
+					(acc: Array<string>, cur: any) => [...acc, cur.pack],
+					[],
+				) as Array<FaithfulPack>
+			)
+				.flat()
+				.filter((e, i, a) => a.indexOf(e) === i)
+				.sort(),
+		);
 	}
 
 	searchContributionsFrom(authors: Array<string>, packs: Array<string>): Promise<Contributions> {

diff --git a/src/v2/repository/firestorm/texture.repository.ts b/src/v2/repository/firestorm/texture.repository.ts
@@ -180,7 +180,7 @@ export default class TextureFirestormRepository implements TextureRepository {
 			.select({
 				fields: ["tags"],
 			})
-			.then((res: any) =>
+			.then((res: Textures) =>
 				(
 					Object.values(res).reduce(
 						(acc: Array<string>, cur: any) => [...acc, cur.tags],

diff --git a/src/v2/service/contributions.service.ts b/src/v2/service/contributions.service.ts
@@ -91,7 +91,7 @@ export default class ContributionService {
 			});
 	}
 
-	getPacks(): FaithfulPack[] {
+	getPacks(): Promise<FaithfulPack[]> {
 		return this.contributionRepo.getPacks();
 	}