Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat/i39] 로그아웃 버튼 생성 #54

Merged
merged 10 commits into from
Nov 5, 2023
Merged

[feat/i39] 로그아웃 버튼 생성 #54

merged 10 commits into from
Nov 5, 2023

Conversation

Ajeong-Im
Copy link
Contributor

🛠️ 변경사항



☝️ 유의사항



❗체크리스트

  • 하나의 메소드는 최소의 기능만 하도록 설정했나요?
  • 수정 가능하도록 유연하게 작성했나요?
  • 필요 없는 import문이나 setter 등을 삭제했나요?
  • 기존의 코드에 영향이 없는 것을 확인하였나요?

Copy link

vercel bot commented Nov 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 7:25pm

Copy link
Contributor

@HyunTaek5 HyunTaek5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿 👍 개인적으로 선호하는 코드 스타일에 대한 코멘트 하나 남겨두었습니다! 작업하시느라 수고하셨어용 😄

}

function AvatarModal({ open, onClose }: AvatarModalProps) {
const [logoutOpen, setLogoutOpen] = useState(false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useState 바로 뒤에 <현재 state의 타입> 방식으로 타입을 명시해두면 혹시라도 나중에 코드 다시 볼일이 생길 때 코드 파악하기 편해서 추천드립니당 👍

코드 예시)
const [logoutOpen, setLogoutOpen] = useState<boolean>(false);

@eric-hjh eric-hjh merged commit 8244fa6 into develop Nov 5, 2023
3 checks passed
@eric-hjh eric-hjh deleted the feat/i39 branch November 5, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants