Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appointment-diary-backend Final #15

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

appointment-diary-backend Final #15

wants to merge 31 commits into from

Conversation

kinginthenorthcodez
Copy link
Collaborator

Appointment-diary-backend final

image

Book vehicle API back-end

  • A friendly api to book vehicle reservations

image
image

LINK to front-end

  • This Project has a React Front-end you can work with

React front-end << open

Backend API LIVE

API LIVE

Built With

  • Ruby on Rails
  • Development set up
  • Rails API only
  • Devise authentication
  • Devise Simple Token Authentication
  • API Swagger documentation
  • Bullet N + 1 queries

git clone https://github.com/Fatima-hub333/appointment-diary-backend

  • Move into project directory

cd hello-rails-back-end

Available Scripts

bundle install

rails server

Available Scripts to Run Test cases

Run following command gem install --no-document rspec -v '>=3.0, < 4.0' > rspec --force-color --format documentation
Uses gem 'rspec-rails' gem 'shoulda-matchers' tests framworks.

Ruby on Rails Testing

Preparing your Application for Testing

  • Before you can run your tests you need to ensure that the test database structure is current. For this you can use the following rake commands:

$ rake db:migrate
...
$ rake db:test:load

$ rails db:seed to seed the app database

  • Above rake db:migrate runs any pending migrations on the developemnt environment and updates db/schema.rb. rake db:test:load recreates the test database from the current db/schema.rb. On subsequent attempts it is a good to first run db:test:prepare as it first checks for pending migrations and warns you appropriately.

Tests using Rspec

  • rails db:test:prepare
  • rake db:migrate

Author

👤 kinginthenorthcodez

GitHub: @kinginthenorthcodez
🤝 Contributing

Author

👤 Bassem Shams

GitHub: @basem909
🤝 Contributing

Author

👤 Fatima Zahir

GitHub: @Fatima-hub333
🤝 Contributing

Contributions, issues, and feature requests are welcome

Api documentation

Note: To release latest 24-10-2022

Show your support

Give a ⭐️ if you like this project!

📝 License
This project is MIT.

Copy link

@Meltrust Meltrust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kinginthenorthcodez,

Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!

To highlight:

  • The app runs well✔️

You can do it

Suggested Changes ♻️

Check the comments under the review.

You can use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend you take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


@@ -1,5 +1,5 @@
require 'rails_helper'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Many tests are not passing for the backend. I followed your instructions exactly as on your readme file. Kindly correct those if they are not working on your end.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants