Merge pull request #152 from BulkSecurityGeneratorProjectV2/fix/JLL/z…

…ip-slip-vulnerability [SECURITY] Fix Zip Slip Vulnerability
FederatedAI · Aug 2, 2022 · 20d17ae · 20d17ae
2 parents 30b81f3 + 0f90869
commit 20d17ae
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/fate-serving-common/src/main/java/com/webank/ai/fate/serving/common/utils/ZipUtil.java b/fate-serving-common/src/main/java/com/webank/ai/fate/serving/common/utils/ZipUtil.java
@@ -54,7 +54,11 @@ public static String unzip(File zipFile, String outputDirectory) throws Exceptio
             while (entries.hasMoreElements()) {
                 ZipEntry entry = entries.nextElement();
 
-                File outputFile = new File(outputDirectory + uuid + File.separator + entry.getName());
+                File outputFile = new File(outputDirectory + uuid, entry.getName());
+
+                if (!outputFile.toPath().normalize().startsWith(outputDirectory + uuid)) {
+                    throw new RuntimeException("Bad zip entry");
+                }
                 if (entry.isDirectory()) {
                     outputFile.mkdirs();
                     continue;