fix bug: urldecode difference between python & java #157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flow load
命令执行时,serving-server会到zookeeper中的/flow/online/transfer
去查询模型地址。fateflow 基于python实现,它写入到 zookeeper 中的地址为
http%3A%2F%2F172.16.0.49%3A9380%2Fv1%2Fmodel%2Ftransfer%2Fguest~10000~guest-10000~host-20000~model%2F202210120948058502700
,可以看到~
保持原样。而java在做urldecode时会将
~
转为%E7
。这会导致原有的实现中,child.endsWith(encodeUri)
永远匹配不到结果目前我的修改办法是:
对zookeeper中读取到的内容直接decode,然后和拼接好的uri进行比较。缺点就是可能会做多次的decode操作。