Skip to content

Commit

Permalink
fix typo (#1)
Browse files Browse the repository at this point in the history
Signed-off-by: weiwee <[email protected]>
  • Loading branch information
sagewe committed Dec 7, 2020
1 parent 3ba05e5 commit 71c3129
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 3 deletions.
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ logs/
FedVision.egg-info/
temp_data/
*.org
/data
!/data/download.sh
2 changes: 1 addition & 1 deletion examples/faster_rcnn/run.sh
Original file line number Diff line number Diff line change
@@ -1 +1 @@
python -m fedvision.framework.cli.submitter submit --config demo.yaml
python -m fedvision.framework.cli.submitter submit --config config.yaml
2 changes: 1 addition & 1 deletion fedvision/framework/abc/job.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def resource_required(self):
def set_required_resource(self, response):
...

def compile(self):
async def compile(self):
...

@abc.abstractmethod
Expand Down
2 changes: 2 additions & 0 deletions fedvision/paddle_fl/job.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,12 @@ async def compile(self):
f"--num-worker {self._worker_num}",
f"--ps-endpoint {self._server_endpoint}",
f"--config config.json",
f">{executor.stdout} 2>{executor.stderr}",
]
)
returncode = await executor.execute(cmd)
if returncode != 0:

raise FedvisionJobCompileException("compile error")

def generate_proposal_request(self) -> coordinator_pb2.Proposal.REQ:
Expand Down
3 changes: 2 additions & 1 deletion fedvision/paddle_fl/tasks/task/trainer.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ async def exec(self, executor: Executor):
f"--feed-names=feed_names",
f"--target-names=target_names",
f"--strategy=strategy",
f"--config config.json" f">{executor.stdout} 2>{executor.stderr}",
f"--config config.json",
f">{executor.stdout} 2>{executor.stderr}",
]
)
with executor.working_dir.joinpath("main_program").open("wb") as f:
Expand Down

0 comments on commit 71c3129

Please sign in to comment.