Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune unused networks #804

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

MNMaqsood
Copy link

Add instruction to prune unused networks by containers, otherwise causes issues on deployment script as same network name exists albeit not used by any container

Fixes ISSUE #xxx

Description

  1. Tell the story why you need to make this change from the user's perspective.
  2. What will be the pain point if you don't make this change?

Tests

Before fix

screenshots, console outputs or logs are acceptable.

After fix

screenshots, console outputs or logs are acceptable.

@JingChen23
Copy link
Collaborator

Actually there is a similar problem in docker volume as well, not only network. Could you please also help to improve the volume part ?

@MNMaqsood
Copy link
Author

@JingChen23 I actually didn't face issue in docker volumes, (faced some issues with docker v2 though but there were not recurring each time).

@MNMaqsood MNMaqsood marked this pull request as ready for review November 30, 2022 08:17
Add instruction to prune unused networks by containers, otherwise causes issues on deployment script as same network name exists albeit not used by any container
@JingChen23 JingChen23 changed the base branch from master to develop-1.10.0 December 5, 2022 04:31
@JingChen23
Copy link
Collaborator

Hi @MNMaqsood , many thanks for your contribution. However, the right process is that you need to checkout a branch from your develop-1.10.0 branch, make a change, and contribute back to our develop-1.10.0 branch.

Could you do that please?

@JingChen23 JingChen23 changed the base branch from develop-1.10.0 to master December 5, 2022 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants