-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken compability with newer versions of css_inline library #43
Comments
Thank you for the report. I'll look into that. I think this was also brought up in #42. Should be a big thing to handle (ideally old + new API ?). |
… old version for now (#43) The "inline_style_tags" parameter for the "CSSInliner" class was removed without an obvious replacement.
Unfortunately the I just noticed that @caseyjhol already filed an issue upstream and the upstream author agreed to reinstante the parameter. |
I'm working on a PR that will pin the css-inline version (but I've been waiting for the latest version with the fix to come out first). I've also discovered another CSS issue related to child selectors that I'll be pushing up a fix for. |
If we want to pin to an old version, we'll need to pin to 0.8.7 as 0.9.0 has been yanked. |
FYI, I am working on a PR that re-introduces the |
The |
Hi @FelixSchwarz!
There was broken changes in css_inline after v0.9.0 interface was changed and now it does not allow inline_style_tags attribute.
Last working v0.9.0
New v0.10.0
Possible solutions:
css_inline.CSSInliner
interface end test how it worksThe text was updated successfully, but these errors were encountered: