Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken compability with newer versions of css_inline library #43

Closed
ididit4you opened this issue Sep 13, 2023 · 6 comments · Fixed by #46
Closed

Broken compability with newer versions of css_inline library #43

ididit4you opened this issue Sep 13, 2023 · 6 comments · Fixed by #46
Assignees

Comments

@ididit4you
Copy link

ididit4you commented Sep 13, 2023

Hi @FelixSchwarz!
There was broken changes in css_inline after v0.9.0 interface was changed and now it does not allow inline_style_tags attribute.

Last working v0.9.0
New v0.10.0

Possible solutions:

  1. Set fixed version in setup.cfg to the v0.9.0
  2. Support the new css_inline.CSSInliner interface end test how it works
@FelixSchwarz
Copy link
Owner

Thank you for the report. I'll look into that. I think this was also brought up in #42. Should be a big thing to handle (ideally old + new API ?).

@FelixSchwarz FelixSchwarz self-assigned this Sep 14, 2023
FelixSchwarz added a commit that referenced this issue Sep 23, 2023
… old version for now (#43)

The "inline_style_tags" parameter for the "CSSInliner" class was removed without
an obvious replacement.
@FelixSchwarz
Copy link
Owner

Unfortunately the inline_style_tags option was removed without an obvious replacement so for now I released mjml-python v0.9.1 which pins the dependency to the old version.

I just noticed that @caseyjhol already filed an issue upstream and the upstream author agreed to reinstante the parameter.

@caseyjhol
Copy link
Contributor

I'm working on a PR that will pin the css-inline version (but I've been waiting for the latest version with the fix to come out first). I've also discovered another CSS issue related to child selectors that I'll be pushing up a fix for.

@caseyjhol
Copy link
Contributor

If we want to pin to an old version, we'll need to pin to 0.8.7 as 0.9.0 has been yanked.

@Stranger6667
Copy link

FYI, I am working on a PR that re-introduces the inline_style_tags option with the same behavior as before.

@Stranger6667
Copy link

The inline_style_tags option is reintroduced in css-inline==0.11.0

This was referenced Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants