Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin css-inline to v0.11 #46

Merged
merged 4 commits into from
Nov 17, 2023

Conversation

caseyjhol
Copy link
Contributor

@caseyjhol caseyjhol mentioned this pull request Sep 29, 2023
@FelixSchwarz FelixSchwarz merged commit 449d707 into FelixSchwarz:main Nov 17, 2023
8 checks passed
@FelixSchwarz
Copy link
Owner

Thank you for your patience. I merged your changes.

I thought about adding an environment marker like css_inline >= 0.11, < 0.12; python_version >= '3.7' in setup.cfg. That way we could have kept the workflow file the same but in the end your solution works as well and gives a clear error message when a Python 3.6 user tries to install css_inline.

I'm curious why you need to add @skipIf though?

@caseyjhol
Copy link
Contributor Author

Hrmm - I think it was maybe so somebody running Python 3.6 could still run tests locally? Maybe it's not strictly necessary.

@FelixSchwarz
Copy link
Owner

Hrmm - I think it was maybe so somebody running Python 3.6 could still run tests locally? Maybe it's not strictly necessary.

Well, with the new version requirements a Python 3.6 should not have css-inline installed so the test should have been skipped anyway. :-)

The only case I can see is a Python 3.6 user with a pre-existing environment who somehow updates his local git checkout while keeping the previous venv. But I don't think we need to support that case.

@caseyjhol
Copy link
Contributor Author

Ah, I think at the time I was thinking we might still be able to have partial css-inline support in 3.6. I'm fine with removing skipIf here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken compability with newer versions of css_inline library
2 participants