Skip to content

Commit

Permalink
Migrate to shared-actions v2
Browse files Browse the repository at this point in the history
> [!IMPORTANT]
> **Please thoroughly review this PR before approving and merging**
> This migration is complicated and may require some manual changes. Below we will call out breaking changes and other important notes.

This PR moves all workflows to the new shared-actions v2. Please check out the following docs for more information on this migration:
- [Migration Guide](https://docs.devops.figure.com/shared-actions/v2-migration-guide)
- [Migration Changes](https://docs.devops.figure.com/shared-actions/v2-migration-changes)

Please reach out to [#github-actions-help](https://figure-group.slack.com/archives/C044W9BRAVD) with any and all questions, someone from devops or core tech will be able to help.

---

### Notes
- Once you've merged in this PR and are running `v2` actions it is worth watching your workflows for warnings about inputs that are no longer used. We are able to handle a lot of replacements automatically, but we err on the side of caution to avoid breaking other github actions that we don't own. These warnings won't ever break your builds, but it is good practice to keep them clean.

🤖🪄 This PR was automatically created by a magic script.
  • Loading branch information
ahatzz11 committed Sep 9, 2024
1 parent 18ff932 commit 82fe8ff
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 17 deletions.
30 changes: 15 additions & 15 deletions .github/workflows/build-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
name: Build API Job Jar
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Get Version
run: |
# Strip git ref prefix from version
Expand All @@ -29,7 +29,7 @@ jobs:
echo "VERSION=$VERSION" >> $GITHUB_ENV
- name: Set up JDK 17
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
java-version: 17
distribution: 'zulu'
Expand All @@ -41,7 +41,7 @@ jobs:
run: ./gradlew service:build -Pversion=$VERSION

- name: Upload aggregator-service-job artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: aggregator-service-job
path: service/build/libs/*.jar
Expand All @@ -52,7 +52,7 @@ jobs:
needs: java_api_job_build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Get Version
run: |
# Strip git ref prefix from version
Expand Down Expand Up @@ -83,7 +83,7 @@ jobs:
install: true

- name: Download Artifact
uses: actions/download-artifact@v2
uses: actions/download-artifact@v4
with:
name: aggregator-service-job
path: service/build/libs
Expand All @@ -107,7 +107,7 @@ jobs:
name: Build Service Jar
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Get Version
run: |
# Strip git ref prefix from version
Expand All @@ -119,7 +119,7 @@ jobs:
echo "VERSION=$VERSION" >> $GITHUB_ENV
- name: Set up JDK 17
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
java-version: 17
distribution: 'zulu'
Expand All @@ -128,7 +128,7 @@ jobs:
run: ./gradlew clean build --refresh-dependencies -Pversion=$VERSION

- name: Upload aggregate-service artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: aggregate-service
path: build/libs/*.jar
Expand All @@ -139,7 +139,7 @@ jobs:
needs: java_service_build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Get Version
run: |
# Strip git ref prefix from version
Expand Down Expand Up @@ -170,7 +170,7 @@ jobs:
install: true

- name: Download Artifact
uses: actions/download-artifact@v2
uses: actions/download-artifact@v4
with:
name: aggregate-service
path: build/libs
Expand All @@ -194,7 +194,7 @@ jobs:
name: Build Migration
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Get Version
run: |
# Strip git ref prefix from version
Expand All @@ -205,7 +205,7 @@ jobs:
echo "VERSION=$VERSION" >> $GITHUB_ENV
- name: Set up JDK 17
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
java-version: 17
distribution: 'zulu'
Expand All @@ -217,7 +217,7 @@ jobs:
run: ./gradlew migrations:build -Pversion=$VERSION

- name: Upload migration artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: aggregate-service-migration
path: migrations/build/libs/*.jar
Expand All @@ -228,7 +228,7 @@ jobs:
needs: migration_build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Get Version
run: |
# Strip git ref prefix from version
Expand Down Expand Up @@ -259,7 +259,7 @@ jobs:
install: true

- name: Download Artifact
uses: actions/download-artifact@v2
uses: actions/download-artifact@v4
with:
name: aggregate-service-migration
path: migrations/build/libs
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Get Version
run: |
Expand All @@ -26,7 +26,7 @@ jobs:
echo "VERSION=$VERSION" >> $GITHUB_ENV
- name: Set up JDK 17
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
java-version: 17
distribution: 'zulu'
Expand Down

0 comments on commit 82fe8ff

Please sign in to comment.