fix: use txResponse events instead of rawLog for parsing AssetClassificationEvents #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgipson-figure
commented
Aug 21, 2024
| key = attribute.key, | ||
| value = attribute.value | ||
| key = attribute.key.toStringUtf8(), | ||
| value = attribute.value.toStringUtf8() |
There was a problem hiding this comment.
rgipson-figure
commented
Aug 21, 2024
| ) | ||
| }, | ||
| fee = sourceTx.tx.authInfo.fee.amountList.firstOrNull()?.amount?.toBigIntegerOrNull(), | ||
| denom = sourceTx.tx.authInfo.fee.amountList.firstOrNull()?.denom, | ||
| note = null | ||
| ), | ||
| inputValuesEncoded = false | ||
| inputValuesEncoded = true |
There was a problem hiding this comment.
The examples I've seen from the txn client have returned the values as encoded for wasm; not sure if rawLogs had them encoded. This will need tested
...main/kotlin/tech/figure/classification/asset/verifier/provenance/AssetClassificationEvent.kt
Outdated
Show resolved
Hide resolved
rgipson-figure
force-pushed
the
hotfix/deprecate-raw-log
branch
from
335edd1
to
d96e450
Compare
rgipson-figure
changed the title
rgipson-figure
changed the title
mtps
previously approved these changes
Aug 21, 2024
hyperschwartz
previously approved these changes
Aug 21, 2024
rgipson-figure
dismissed stale reviews from hyperschwartz and mtps
via
39ffa39
mtps
approved these changes
Aug 21, 2024
hyperschwartz
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Failed calling
manualVerifyHashagainst a txn in provenance 1.9.0 due torawLogbeing an empty string (possibly deprecated) when parsing for AssetClassificationEventsChanges
Use the events from the cosmos proto for mapping to AssetClassificationEvents