Piercetrey figure/sc 253074/update to blockapi #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piercetrey-figure
commented
Aug 16, 2023
•
piercetrey-figure
commented
- Using blockapi for the event listening instead of the event stream
- Updated to Java 17
|
This pull request has been linked to Shortcut Story #253074: Update object store gateway to use blockapi. |
server/src/main/kotlin/tech/figure/objectstore/gateway/components/BlockStreamConsumer.kt
Show resolved
Hide resolved
| ).collect { block -> | ||
| val lastProcessedHeight = blockHeightRepository.getLastProcessedBlockHeight() | ||
|
|
||
| block.blockResult.block.transactionsList.flatMap { it.eventsList } |
There was a problem hiding this comment.
took me a while to figure out that block.blockResult.transactions.transactions.transactionsList was an empty red herring 🤦
There was a problem hiding this comment.
Yea, there's a branch out there to nix that out that's about 8 months old.
mtps
reviewed
Aug 16, 2023
mtps
previously approved these changes
Aug 16, 2023
|
going to adjust this to be pluggable between event stream and blockapi since this is public and might need to be more flexible |
server/src/main/kotlin/tech/figure/objectstore/gateway/components/BlockStreamConsumer.kt
Outdated
Show resolved
Hide resolved
server/src/main/kotlin/tech/figure/objectstore/gateway/components/BlockStreamConsumer.kt
Show resolved
Hide resolved
server/src/main/kotlin/tech/figure/objectstore/gateway/components/BlockStreamConsumer.kt
Show resolved
Hide resolved
server/src/main/kotlin/tech/figure/objectstore/gateway/configuration/BlockStreamConfig.kt
Show resolved
Hide resolved
hyperschwartz
previously approved these changes
Aug 18, 2023
mtps
previously approved these changes
Aug 18, 2023
piercetrey-figure
dismissed stale reviews from mtps and hyperschwartz
via
2bf2761
hyperschwartz
approved these changes
Aug 21, 2023
piercetrey-figure
deleted the
piercetrey-figure/sc-253074/update-to-blockapi
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.