Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizations for MultiTenantAuthenticationSchemeProvider #878

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MarkCiliaVincenti
Copy link

No description provided.

@AndrewTriesToCode
Copy link
Sponsor Contributor

Hi @MarkCiliaVincenti this is an interesting PR, thank you. I will be reviewing but just a heads up I have to be somewhat conservative in that I support older version of .NET and C# and also only take dependency on core .NET packages. I really like the use of Lock here but I can't yet use preview language settings for the overall project and I can't take a dependency on the 'Backport` library.

I will ultimately rotate these updates in as .NET 9 releases and do something like:

#if NET9_0_OR_GREATER
global using Lock = System.Threading.Lock;
#else
global using Lock = System.Object;
#endif

@MarkCiliaVincenti
Copy link
Author

That would work but would limit what you can do, basically not call any of the methods offered by the new lock class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants