Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue 53: FlxU.RotatePoint #128

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fixing issue 53: FlxU.RotatePoint #128

wants to merge 1 commit into from

Conversation

SeiferTim
Copy link

Should use subtract and not add for dy.

Should use subtract and not add for dy.
@Dovyski
Copy link
Member

Dovyski commented Dec 28, 2012

That's strange, maybe some charset change.

About the fix itself, have you checked if this change does not affected any other parts of Flixel? I've read in issue #53 that FlxU.getAngle() uses it and expects the "old and wrong" values.

@moly
Copy link
Member

moly commented Jan 11, 2013

This fix breaks path following, objects will now travel away from the next node instead of towards it. FlxU.rotatePoint is used here: https://github.com/FlixelCommunity/flixel/blob/dev/org/flixel/FlxObject.as#L662

I suspect the problem is that FlxU.getAngle contains a similar error.

@Dovyski
Copy link
Member

Dovyski commented Apr 9, 2013

Are you still working on this fix, @SeiferTim ?

@moly moly mentioned this pull request May 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants