Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add package to generated assets, pt.2 #439

Merged
merged 5 commits into from
Oct 27, 2023
Merged

Conversation

AlexV525
Copy link
Member

What does this change?

Further updates to #401.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
    • Ensure the tests (melos run test)
    • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)
  • Appropriate docs were updated (if necessary)

@AlexV525
Copy link
Member Author

cc @bramp

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #439 (9115aa7) into main (76bd39e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #439   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files          20       20           
  Lines         698      700    +2     
=======================================
+ Hits          686      688    +2     
  Misses         12       12           
Files Coverage Δ
packages/core/lib/generators/assets_generator.dart 98.15% <ø> (ø)
.../core/lib/generators/integrations/integration.dart 100.00% <ø> (ø)
...ib/generators/integrations/lottie_integration.dart 93.10% <100.00%> (+0.24%) ⬆️
...e/lib/generators/integrations/svg_integration.dart 100.00% <100.00%> (ø)

@AlexV525 AlexV525 merged commit 44d743d into main Oct 27, 2023
5 checks passed
@AlexV525 AlexV525 deleted the feat/package-assets-pt2 branch October 27, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants