Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support build.yaml to configure #555

Merged
merged 5 commits into from
Sep 7, 2024

Conversation

b2nkuu
Copy link
Contributor

@b2nkuu b2nkuu commented Aug 17, 2024

What does this change?

Read config build.yaml and replacement configure after default, pubspec.yaml.

Priority of configuration file.
High ---> Low
build.yaml -> pubspec.yaml -> default_config

Fixes #114 🎯

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
    • Ensure the tests (melos run test)
    • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)
  • Appropriate docs were updated (if necessary)

@AlexV525
Copy link
Member

Could you clarify the priority when both configs in pubspec.yaml and build.yaml exist?

@b2nkuu
Copy link
Contributor Author

b2nkuu commented Aug 28, 2024

Could you clarify the priority when both configs in pubspec.yaml and build.yaml exist?

Yep, Priority of configuration file.
High ---> Low
build.yaml -> pubspec.yaml -> default_config

@AlexV525
Copy link
Member

Yep, Priority of configuration file. High ---> Low build.yaml -> pubspec.yaml -> default_config

Thanks, in this case I would like to see if we can log what configuration the gen command is using, probably like: Reading FlutterGen options from xxxx.xxx..

@b2nkuu
Copy link
Contributor Author

b2nkuu commented Sep 1, 2024

Yep, Priority of configuration file. High ---> Low build.yaml -> pubspec.yaml -> default_config

Thanks, in this case I would like to see if we can log what configuration the gen command is using, probably like: Reading FlutterGen options from xxxx.xxx..

Got it.
I will add command to select file to read and default at pubspec.yaml
OK?

@AlexV525
Copy link
Member

AlexV525 commented Sep 1, 2024

Got it. I will add command to select file to read and default at pubspec.yaml OK?

We might focus on one specific feature in one request. Besides, we don't need such rich options AFAICT.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (cf7b2a7) to head (c2f70f2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
+ Coverage   97.52%   97.55%   +0.03%     
==========================================
  Files          24       24              
  Lines         848      860      +12     
==========================================
+ Hits          827      839      +12     
  Misses         21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
packages/core/test_resources/build_output.yaml Outdated Show resolved Hide resolved
Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for committing to all of the suggestions!

@AlexV525 AlexV525 merged commit d29f6bd into FlutterGen:main Sep 7, 2024
5 checks passed
@AlexV525 AlexV525 added this to the 5.8.0 milestone Oct 1, 2024
@AlexV525 AlexV525 mentioned this pull request Oct 1, 2024
wasabeef pushed a commit that referenced this pull request Oct 8, 2024
## 5.8.0

**Feature**
- [#555](#555) Support
build.yaml to configure. by [@b2nkuu](https://github.com/b2nkuu)
- [#567](#567) Generate
the `package` constant for generated font classes. by
[@TesteurManiak](https://github.com/TesteurManiak)
- [#569](#569) Enables
`gaplessPlayback` by default for image assets. by
[@AlexV525](https://github.com/AlexV525)
- [#580](#580) Allows
`mime: '>=1.0.0 <3.0.0'`. by [@AlexV525](https://github.com/AlexV525)

**Development**
- [#563](#563) Fix
concurrency execution with melos. by
[@wasabeef](https://github.com/wasabeef)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] build.yaml configuration instead of pubspec.yaml
2 participants