Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix concurrency execute with melos. #563

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Conversation

wasabeef
Copy link
Member

@wasabeef wasabeef commented Aug 28, 2024

What does this change?

I limited concurrent execution because these logs were being output during the execution of the flutter command.

When melos run get

ERROR: ERROR: [example]: Waiting for another flutter command to release the startup lock...
ERROR: ERROR: [flutter_gen]: Waiting for another flutter command to release the startup lock...
ERROR: ERROR: [flutter_gen_runner]: Waiting for another flutter command to release the startup lock...

And fix analyze.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
    • Ensure the tests (melos run test)
    • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)
  • Appropriate docs were updated (if necessary)

melos.yaml Show resolved Hide resolved
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.52%. Comparing base (38f121f) to head (41de148).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #563   +/-   ##
=======================================
  Coverage   97.52%   97.52%           
=======================================
  Files          24       24           
  Lines         848      848           
=======================================
  Hits          827      827           
  Misses         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

melos.yaml Show resolved Hide resolved
melos.yaml Outdated Show resolved Hide resolved
Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@wasabeef wasabeef merged commit 9247b38 into main Sep 3, 2024
5 checks passed
@wasabeef wasabeef deleted the chore-melos-settings branch September 3, 2024 09:43
@AlexV525 AlexV525 added this to the 5.8.0 milestone Oct 1, 2024
@AlexV525 AlexV525 mentioned this pull request Oct 1, 2024
wasabeef pushed a commit that referenced this pull request Oct 8, 2024
## 5.8.0

**Feature**
- [#555](#555) Support
build.yaml to configure. by [@b2nkuu](https://github.com/b2nkuu)
- [#567](#567) Generate
the `package` constant for generated font classes. by
[@TesteurManiak](https://github.com/TesteurManiak)
- [#569](#569) Enables
`gaplessPlayback` by default for image assets. by
[@AlexV525](https://github.com/AlexV525)
- [#580](#580) Allows
`mime: '>=1.0.0 <3.0.0'`. by [@AlexV525](https://github.com/AlexV525)

**Development**
- [#563](#563) Fix
concurrency execution with melos. by
[@wasabeef](https://github.com/wasabeef)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants