Porting to GNOME 45 #179
Merged
Porting to GNOME 45 #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does the preferences window work for you as well? And I don't know how I missed adding the settings.ui |
|
Yep, Preference windows is working for me now. |
|
@ff2400t, I'm surprised you didn't have to make any alterations to the keybindings.js I'll make some small adjustments to your code before I merge it in. But thanks for doing the G45 legwork. I've been dragging my feet until Ubuntu forces it on me in the spring. |
change sourceType to module
|
@GrylledCheez Now that the linting is ok, could you merge this and release a version that supports G45. Fedora 39 (and soon 40) have been using it for some time now. |
change shell-version to 45
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works fine on my fedora 39 with GNOME 45. It has code for both Gnome 45 and versions before with comments showing which sections work for which version. The code for the older version is commented out. This was based on this comment by @GrylledCheez in #165 (comment)_
I also added settings.ui to the build package which was not included in build.sh script before.