Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][IMP] rma: add date to rma_order_line #432

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

DavidJForgeFlow
Copy link
Contributor

Adds date to rma lines. Missing migration script to get default values in already existing databases.

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2023

Codecov Report

Merging #432 (f155deb) into 14.0 (a8727de) will decrease coverage by 0.04%.
The diff coverage is 68.75%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             14.0     #432      +/-   ##
==========================================
- Coverage   80.72%   80.68%   -0.04%     
==========================================
  Files         156      156              
  Lines        4862     4878      +16     
  Branches      897      904       +7     
==========================================
+ Hits         3925     3936      +11     
- Misses        728      730       +2     
- Partials      209      212       +3     
Files Coverage Δ
rma/models/rma_order_line.py 78.40% <100.00%> (+0.18%) ⬆️
rma/models/rma_order.py 82.78% <61.53%> (-2.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8727de...f155deb. Read the comment docs.

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the date_rma is set in the rma group all the lines should take that date I think.

@AaronHForgeFlow AaronHForgeFlow changed the title [WIP][14.0][IMP] rma: add date to rma_order_line [14.0][IMP] rma: add date to rma_order_line Oct 27, 2023
@AaronHForgeFlow
Copy link
Contributor

@DavidJForgeFlow as long the date is in the rma group I think it makes sense to be consistent with the date in the lines, do you agree?

@AaronHForgeFlow
Copy link
Contributor

The same PR is merged in v16 so I am merging this here to keep branches even

@AaronHForgeFlow AaronHForgeFlow merged commit 74aee1d into 14.0 Nov 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants