-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] rma_purchase_analytic #447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Minor comments
0010838
to
67f9d8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JasminSForgeFlow some minor comments before the merge
67f9d8f
to
e98a060
Compare
@AaronHForgeFlow it is now rebased, was issue in rebase |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 15.0 #447 +/- ##
==========================================
- Coverage 80.68% 80.60% -0.08%
==========================================
Files 144 149 +5
Lines 4830 4858 +28
Branches 754 756 +2
==========================================
+ Hits 3897 3916 +19
- Misses 720 728 +8
- Partials 213 214 +1
Continue to review full report in Codecov by Sentry.
|
e98a060
to
2fd243e
Compare
@JasminSForgeFlow , there are some merge commits in the commit history that should not be there. Also there are still conflicts in the PR so I can still not merge. Have you fetched the latest code in 15.0 before the rebase? |
[FIX]various
[FIX]rma_purchase_analytic
2fd243e
to
d1fc290
Compare
I did rebase but maybe something went wrong. I have just followed the migration process and pushed it so it is up to date now |
@JasminSForgeFlow now the history looks good. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works same as in previous versions.
I miss some features like filling in the analytic account in the RMA line when selecting a source PO, but that can be done in another PR.
No description provided.