Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] rma_purchase_analytic #447

Merged
merged 8 commits into from
Sep 29, 2023

Conversation

JasminSForgeFlow
Copy link
Collaborator

No description provided.

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor comments

rma_purchase_analytic/__manifest__.py Outdated Show resolved Hide resolved
rma_purchase_analytic/__manifest__.py Outdated Show resolved Hide resolved
rma_purchase_analytic/models/__init__.py Show resolved Hide resolved
rma_purchase_analytic/wizards/__init__.py Outdated Show resolved Hide resolved
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JasminSForgeFlow some minor comments before the merge

rma_sale_operating_unit/README.rst Outdated Show resolved Hide resolved
rma_sale_operating_unit/README.rst Outdated Show resolved Hide resolved
rma_sale_operating_unit/README.rst Outdated Show resolved Hide resolved
@JasminSForgeFlow
Copy link
Collaborator Author

JasminSForgeFlow commented Sep 26, 2023

@AaronHForgeFlow it is now rebased, was issue in rebase

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Merging #447 (d1fc290) into 15.0 (4e7ebc7) will decrease coverage by 0.08%.
The diff coverage is 67.85%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             15.0     #447      +/-   ##
==========================================
- Coverage   80.68%   80.60%   -0.08%     
==========================================
  Files         144      149       +5     
  Lines        4830     4858      +28     
  Branches      754      756       +2     
==========================================
+ Hits         3897     3916      +19     
- Misses        720      728       +8     
- Partials      213      214       +1     
Files Coverage Δ
rma_purchase_analytic/__init__.py 100.00% <100.00%> (ø)
rma_purchase_analytic/models/__init__.py 100.00% <100.00%> (ø)
rma_purchase_analytic/wizards/__init__.py 100.00% <100.00%> (ø)
...ma_purchase_analytic/models/purchase_order_line.py 62.50% <62.50%> (ø)
rma_purchase_analytic/wizards/rma_add_purchase.py 62.50% <62.50%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e7ebc7...d1fc290. Read the comment docs.

@AaronHForgeFlow
Copy link
Contributor

@JasminSForgeFlow , there are some merge commits in the commit history that should not be there. Also there are still conflicts in the PR so I can still not merge. Have you fetched the latest code in 15.0 before the rebase?

@JasminSForgeFlow
Copy link
Collaborator Author

@JasminSForgeFlow , there are some merge commits in the commit history that should not be there. Also there are still conflicts in the PR so I can still not merge. Have you fetched the latest code in 15.0 before the rebase?

I did rebase but maybe something went wrong. I have just followed the migration process and pushed it so it is up to date now

@AaronHForgeFlow
Copy link
Contributor

@JasminSForgeFlow now the history looks good. Thanks.

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works same as in previous versions.

I miss some features like filling in the analytic account in the RMA line when selecting a source PO, but that can be done in another PR.

@AaronHForgeFlow AaronHForgeFlow merged commit 3420ff9 into 15.0 Sep 29, 2023
4 checks passed
@AaronHForgeFlow AaronHForgeFlow deleted the 15.0-mig-rma_purchase_analytic branch September 29, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants