[17.0][MIG] rma_sale #516
Open
[17.0][MIG] rma_sale #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronHForgeFlow
force-pushed
the
17.0-mig-rma_sale-good
branch
from
1c08876
to
2362e37
Compare
AaronHForgeFlow
commented
May 6, 2024
AaronHForgeFlow
force-pushed
the
17.0-mig-rma_sale-good
branch
from
c64aac5
to
1fbbf0f
Compare
|
Ready for the merge IMHO |
AaronHForgeFlow
force-pushed
the
17.0-mig-rma_sale-good
branch
from
1fbbf0f
to
3b903d8
Compare
* fix assignment of moves. * default qty in rma lines. * remove account dependency. * test and flake8 fixes.
… supplier [IMP]Separate menus for customer and supplier operations * Add active field to rma operation * Added tests * Fix travis * Fix create supplier rma from customer rma
* rma: receipt_policy selections not matching. * rma_sale: fix _prepare_rma_line_from_sale_order_line.
* remove unneded copy attributes. * simplify action_view methods. * fix wrong naming. * fix misplaced views. * fix wrong count and view actions for rma.orders in invoices. * fix error when installing the module. * remove unneded data update when preparing rma lines from invoice lines. * minor extra fixes.
* simplify actgion_view methods. * remove unneded copy and ondelete attributes. * Fix wizard to add rma lines from SO. * Update README and some strings.
Hide button and fields depending on the policy chosen on the rma line
- auto_confirm_rma_sale - free_of_charge_rma_sale
OCA was added in the past by mistake only because a misconfiguration in the CI forced OCA as a required author.
Otherwise the anglo saxon entries won't be correct. For example, the Interim (Delivered) account should balance after receiving and triggering a refund on a customer rma.
Without this, some policies are not being copied from the operation selected when creating new rma line from a rma group. In v16 this patch and the usage of such onchange can be removed in favor of (pre)computed stored editable fields for all policies and configuration in the RMA operation.
…ma lines created (#452) * [14.0][IMP] added default operation on rma group, easy setup before rma lines created * [IMP] added fields for default route created by wizard on rma group * fix: get right price after create rma order line
& convert name_get to compute_diplay_name
…ve lines by default This allow to manage phantom bom products, by creating rma lines for the components instead of the kit if the option is activated.
AaronHForgeFlow
force-pushed
the
17.0-mig-rma_sale-good
branch
from
11bdd0c
to
6d383af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #507
Respected original code & history
Reasons for supersede:
Merge 17.0 was broken after merging and reverting by mistake some pull requests: #483 & #500
History was incorrect showing merge commits within it.
Merge conflicts when trying to manually merge other PRs on top on that one.
Unable to see the changes in the migration commit, making hard for the reviewer to review the code
Sorry for the inconvenience.
https://github.com/ForgeFlow