fix: prefetch crash #1010
Merged
fix: prefetch crash #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 3b15076 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
it was possible that the issuer could be an empty string ('') which would indeed cause the app to crash, since our `invariant` check missed that.
fixes #478
Update index.js
Create short-lies-behave.md
zibs
force-pushed
the
fix/478-prefetch-crash
branch
from
78a7f3e
to
3b15076
Compare
carbonrobot
approved these changes
Aug 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #478
Description
it was possible that the issuer could be an empty string ('') which would indeed cause the app to crash, since our
invariantcheck missed that.This is a required field, and the docs mention it, and the user must supply it in order for the functionality to work, but in the case that it's missed or forgotten, this is better than hard crashing as it was.
Steps to verify
issuer: '',and see app hard crash