Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable flipper on iOS and Android in Example #989

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

zibs
Copy link
Contributor

@zibs zibs commented Jun 10, 2024

Fixes #...

Description

Was running into build issues, and Flipper is generally deprecated now anyways, so I don't think it's worth fighting against just to run the demo app.

This is just the simplest way to remove it. It doesn't remove all the related Flipper code that would be removed later on when we upgrade the demo app etc.

Steps to verify

Was running into build issues, and Flipper is generally deprecated now anyways, so I don't think it's worth fighting against just to run the demo app
Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-app-auth ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 8:17pm

Copy link

changeset-bot bot commented Jun 10, 2024

⚠️ No Changeset found

Latest commit: 4a89e9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@carbonrobot carbonrobot merged commit 4e630a9 into main Jun 10, 2024
3 checks passed
@carbonrobot carbonrobot deleted the chore/disable-flipper branch June 10, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants