Adjust access to synthesis functions. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand why the test is failing. The data download part has not been touched. Any idea @nichollsh ? |
|
It's not immediately obvious to me but I will check on my machine locally to see if this is reproducible. |
|
I've noticed that sometimes the OSF download fails, so maybe it's that actually (see FormingWorlds/PROTEUS#206) |
|
@lsoucasse I didn't change any code but re-ran the failing test, and now it seems to be okay. I think this is mostly certainly the same problem as FormingWorlds/PROTEUS#206 It's probably fine to merge this PR if the tests complete when re-running them a second time. |
nichollsh
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust access to synthesis functions so that we can use whole track data generated on the proteus side.