-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ls/fixed rosenbrock #28
Conversation
Fast work, thanks @lsoucasse. Does the Rosenbrock method roughly reproduce the results of the Euler method? |
Yes, you can actually compare them as I kept same input for the two tests (Rosenbrock/Euler). Highest differences are of the order of 5% for XUV fluxes as spotted earlier with the adaptive Rosenbrock. |
Actually I also ran the Proteus test (physical integration) and only escape rate is affected (which makes sense). |
I agree that that makes sense. If we run PROTEUS with the updated version of MORS, will it then automatically use this new integrator by default? |
Yes, I switch this new time scheme as the default as discussed this morning. I already have a proteus branch with updated test values. I will open a PR once pyPI release is published. |
If you want to run with previous time stepping scheme use: |
This work implements the Rosenbrock timestepping scheme for computation of stellar evolution quantities with a fixed time grid (though increasing timestep).
To determine the time grid, I ran the adaptive Rosenbrock scheme and plot the time step as a function of time. I roughly obtained a power law dAge = 0.1 Age^0.75 (Myr). I added a capping to a maximum time step of 50 Myr for further accuracy.
This time step is now set as the default one. I added a test but kept the one using the ForwardEuler scheme.