Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests sometimes fail during FWL data download #206

Open
nichollsh opened this issue Oct 16, 2024 · 0 comments
Open

Tests sometimes fail during FWL data download #206

nichollsh opened this issue Oct 16, 2024 · 0 comments
Labels
bug Something isn't working JOSS publication: PROTEUS TBD before PROTEUS JOSS publication Priority 3: standard Priority level 3: medium time criticality or importance software Relating to software and implementation

Comments

@nichollsh
Copy link
Contributor

Sometimes the tests fail because the model is not able to get data from OSF. This can usually be fixed by requesting the test to be run again, in which case the data usually downloads fine.

Example of it failing: https://github.com/FormingWorlds/PROTEUS/actions/runs/11366750494/job/31617828810

We could include a loop in the downloader functions that re-attempts the download if an error is thrown.
@nichollsh nichollsh added the bug Something isn't working label Oct 16, 2024
@nichollsh nichollsh changed the title Tests fail during FWL data download Tests sometimes fail during FWL data download Oct 22, 2024
This was referenced Oct 24, 2024
Merged
Open
@lsoucasse lsoucasse added the software Relating to software and implementation label Nov 11, 2024
@timlichtenberg timlichtenberg added Priority 3: standard Priority level 3: medium time criticality or importance JOSS publication: PROTEUS TBD before PROTEUS JOSS publication labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working JOSS publication: PROTEUS TBD before PROTEUS JOSS publication Priority 3: standard Priority level 3: medium time criticality or importance software Relating to software and implementation
Projects
PROTEUS Development Roadmap
Status: JOSS Publication
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timlichtenberg @nichollsh @lsoucasse