-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalise stellar wrapper, dummy star module #220
Conversation
…ey don't apply to the dummy star module
…eus.py since it's redundant with the CLI
…w inside star.wrapper.init_star()
… planck function is near zero
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but @lsoucasse should also give it a quick check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes! I will probably extend the baraffe_track property of proteus into a star_track to store either spada or baraffe data for the whole run.
The dummy star simulation seens to run fine on my laptop.
That makes sense - I guess this is covered by #167 ? |
Thanks both! |
Yes! |
This PR adds a dummy star module. It calculates the stellar spectrum and bolometric luminosity assuming that the star emits like a blackbody with a temperature and radius specified by the user. Added
dummy_star.toml
configuration to demonstrate this, but there isn't a test for this yet. Closes #202.It also reworks the stellar module handling to generalise calculations between the mors and dummy modules. This mostly means moving functions into
src/proteus/star/
and calling these fromproteus.py
. This also meant moving a lot of variables inproteus.py
into theProteus
class, which will also be useful for later work (e.g. #204, #162).Minor things:
Lbol
config variable tolum_now
, to make it clear that this is the modern luminosity of the star.phys.py
for containing physics functions.start_proteus.py
since it is made redundant by the CLI.