-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the user's registration year to the earliest year available in the calendar #1611
base: stable
Are you sure you want to change the base?
Conversation
This is not the right way. For example, I am registered on May 2015 when freefeed.net was launched, but my oldest posts are from 2009 (because I imported my archive with posts from friendfeed.com). |
Oh, you are right. I completely forgot about the tool for importing the archive from Friendfeed. I think we should set the first post date to it. What do you think? |
It's doable, but to be honest I don't see the value of doing so. There is no simple way of finding out what the date of the first post of a user is, so you'd need to do a bit of work on the backend to make that work first, and then pass this data to the frontend, and then use it here. I do not think that the problem is worth the fix. |
We already have the seeds for this in the API, when we show posts by day. When shown by year, we could return the previous and next non-empty years. If there is no such previous year, then the posts have run out. |
Honestly, I'm having trouble understanding your statement. Could you please clarify? What I observed is that the calendar allows me to go back to the year 2000, but my first post on this account is from 2021. It doesn't seem to make much sense to have the ability to view previous years with no data in them. |
@MMDJafari what @davidmz is talking about is taking the "next/previous day/month with posts" functionality that we already use on day/month views on calendar page, and putting it to use on year view as well. Right now we simply show all possible years and users can navigate between them even if they have no posts, and instead we could change this to navigating only between non-empty years. However, I think I don't like skipping empty years, so if I had posts only in 2020 and in 2022 then I would like to be able to click "← 2021" from 2022 and see an empty 2021, then click "← 2020" again and see 2020 with posts. But I agree that letting users navigate past that is not useful. |
Now I understand what he meant. Thankful.
In this case, I don't want to skip 2021 either, but showing the years before 2020 is not very logical.
To recognize scenario 2, we can use a flag if it exists. As I mentioned earlier, I observed some elements in the state. Since I didn't import anything, I can't test them. Could you please log the state in your console and send me a screenshot like the one I posted before? Here's the link to my previous post for reference: #1611 (comment) |
No description provided.